Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

Can you also add test cases that show the impact of this change?

Can you also add test cases that show the impact of this change?

Hi @arthurschreiber
I’ve been testing a few scenarios to validate the impact of this change, and I think this testcase demonstrates the expected behavior -

[
  {
    "comment": "Derived table pushdown optimization",
    "query": "SELECT * FROM (SELECT DISTINCT col FROM user.ref WHERE col = 1 LIMIT 10) as sub",
    "plan": {
      "Type": "Passthrough",
      "QueryType": "SELECT",
      "Original": "SELECT * FROM (SELECT DISTINCT col FROM user.ref WHERE col = 1 LIMIT 10) as sub",
      "Instructions": {
        "OperatorType": "Route",
        "Variant": "Reference",
        "Keyspace": {
          "Name": "user",
          "Sharded": true
        },
        "FieldQuery": "select col from (select col from ref where 1 != 1) as sub where 1 != 1",
        "Query": "select col from (select distinct col from ref where col = 1 limit 10) as sub"
      },
      "TablesUsed": [
        "user.ref"
      ]
    }
  }
]

Properties of the query -

• user.ref is a Reference table (replicated across shards)
• Subquery contains LIMIT, making the operator non-mergeable thus !op.IsMergeable(ctx) condition becomes true.
• Routing opcode is Reference, which is now recognized as single-shard thus !innerRoute.Routing.OpCode().IsSingleShard() condition becomes false

These are the test results in both scenarios

Previous Case (EqualUnique-only):

• isMergeable = false
• opcode = Reference
• Pushdown is blocked, even though the route is actually single-shard
• vtgate must perform DISTINCT + LIMIT

Output -

Refactored Case (using IsSharded):

• IsSingleShard() = true for Reference variant
• Pushdown is allowed
• MySQL executes the entire subquery

Output -

What do you think?

Hi @arthurschreiber just following up on my previous comment.
Let me know what do you think of the test case provided.
Thanks!

@ChaitanyaD48 The test case makes sense to me. 👍

Thanks! @arthurschreiber
I've added the test case to reference_cases.json

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.90%. Comparing base (4a3e6a3) to head (a0c21e3).
⚠️ Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main   #18974      +/-   ##
==========================================
- Coverage   69.91%   69.90%   -0.01%     
==========================================
  Files        1613     1613              
  Lines      216122   216124       +2     
==========================================
- Hits       151097   151086      -11     
- Misses      65025    65038      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.